Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As I was trying to set up the project on my laptop, I noticed some inconsistencies with how Bower was integrated. So, I took some time to work on it:
node_modules
is created whennpm install
is run and it contains all modules specific to the project (in our case, only Bower). This solution is a lot more clean since it takes some of the good ways from virtual environments (like installing things per project).npm install
is now run automatically viamake install
. So, it ensures Bower is always installed.bower.json
has been renamed fromDjango Project
todjangoproject
. My main concern was that such name is not permitted in Node.js modules. So, I had to stick with something consistent among all files anddjangoproject
seemed to be a good name.PATH
withnode_modules/.bin
but you have to run Bower from the root directory... The second solution is to use thescripts
section from Npm. Commands like Bower could be run like this after that:npm run bower install
. It chose that solution.I think that is all. If you have any question, feel free to ask. If you want some modifications to the pull request or spot any mistake, I am listening.