Added invisible reCaptcha to donatations form.
#928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @cgl. Thanks for this! I will take a full look after the releases on Thursday. ⭐️ |
|
This looks good to me 👍. If you're happy with it @carltongibson merge it! |
carltongibson
force-pushed
the
recapthca-v3-integration
branch
from
63464a6
to
cb85007
Compare
carltongibson
changed the title
invisible reCaptcha to donatations form.
carltongibson
force-pushed
the
recapthca-v3-integration
branch
from
cb85007
to
87960cc
Compare
felixxm
reviewed
Aug 13, 2019
djangoproject/templates/fundraising/includes/donation_form_with_heart.html
Outdated
Show resolved
Hide resolved
carltongibson
force-pushed
the
recapthca-v3-integration
branch
from
87960cc
to
be20017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a conceptial PR for adding Google Invisible reCAPTCHA to stripe payment process. (cc: @carltongibson @frankwiles )
It has a dependency on django-recaptcha package.
It basicly does an invisible captcha check before opening stripe modal. Recaptcha v3 requires a server side call to google in order to verify user interaction. That is also included in the implementation.
If there is a different requirement on the placement of the captcha it can easily be moved to that location. But this version prevents those users who fails the captcha check to enter their credit card information (and use stripe to check validation of those card information)
Settings are temporary, should be updated for prod use. Tests should be added as well.