Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh dependencies and split requirements.txt between dev and production #24

Merged
merged 3 commits into from
May 20, 2013

Conversation

dplanella
Copy link
Contributor

While installing Cab, I noticed that there was a missing dependency on Whoosh (for django-haystack) on the requirements.txt file.

It turns out that this dependency is only required in a development environment, so as suggested on the discussion thread, I ended up splitting the requirements files for development/production.

@zerok
Copy link
Contributor

zerok commented Apr 7, 2013

Whoosh is not necessarily a dependency since we only use it in the development environment. djangosnippets itself IIRC uses SOLR. We should probably split up the requirements.txt to make this more apparent :-)

@dplanella
Copy link
Contributor Author

@zerok ok, I've finally had some time to look into this and I've implemented your suggestion of splitting the development and production requirements.txt file. Let me know what you think.

@dplanella
Copy link
Contributor Author

Looking at it in more detail, is there a particular reason to use an old snapshot of django-storages (https://bitbucket.org/jezdez/django-storages/get/f312d8bc7520.zip) instead of a newer, standard release?

@zerok
Copy link
Contributor

zerok commented May 19, 2013

Sorry for the delay and thank your work on this one :-)

AFAIK keeping current with django-storages should be fine. I will look over it and ideally merge it someone today.

zerok added a commit that referenced this pull request May 20, 2013
Refresh dependencies and split requirements.txt between dev and production
@zerok zerok merged commit 7e5b646 into django:master May 20, 2013
@dplanella
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants