Update URLconfs to use django.urls.path() #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
reviewed
Nov 15, 2018
cab/urls/bookmarks.py
Outdated
| bookmarks.delete_bookmark, | ||
| name='cab_bookmark_delete'), | ||
| path('', | ||
| bookmarks.user_bookmarks, |
There was a problem hiding this comment.
I'd like to follow Django's guideline of allowing lines long than 79 characters if it helps readability. I would single line all the path()s
There was a problem hiding this comment.
I agree with you but I didn't want to change these lines. I changed now
ratings/converters.py
Outdated
| @@ -0,0 +1,8 @@ | |||
| class FloatConverter: | |||
| regex = '[+-]?([0-9]*[.])?[0-9]+' | |||
There was a problem hiding this comment.
Is the plus sign required? I don't see it in the orignal regex or any test failing without it.
There was a problem hiding this comment.
you are right, I erased it
ratings/converters.py
Outdated
| regex = '[+-]?([0-9]*[.])?[0-9]+' | ||
|
|
||
| def to_python(self, value): | ||
| return value |
There was a problem hiding this comment.
You can move the some type conversion from the rate_object view to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.