[fix] Added missing float type to InBBoxFilter schema #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the patch. I have started the CI |
auvipy
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Your commit message does not follow our commit message style guidelines:
- missing prefix in the commit short description
Eg: "[feature/fix/change] Action performed"
Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
nemesifier
reviewed
Aug 31, 2022
There was a problem hiding this comment.
Thanks for the fix @astanishevskyi! Changing the commit message to '[fix] Added missing float type to InBBoxFilter schema` will fix the QA check.
astanishevskyi
changed the title
|
@nemesisdesign thank you, fixed |
astanishevskyi
requested review from
nemesifier and
auvipy
and removed request for
auvipy and
nemesifier
|
its still failing |
I meant to amend the commit message with the text I indicated and force push it, eg: |
astanishevskyi
force-pushed
the
master
branch
from
81df9dc
to
bcddec6
Compare
|
@nemesisdesign oh, sorry. Now fixed for sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typing in
InBBoxFilterandDistanceToPointFilter. The only possible values fortypeare['array', 'boolean', 'integer', 'number', 'object', 'string']. Butfloatcan be used as format ofnumber.Refarence to Swagger Documentation Data Types