Fields will not read what it writes #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When to_representation is run on a geo object json.load adds unicode strings so the result is something like:
```
{u'type': u'Point', u'coordinates': [39.921092168090915, 28.04062843322754]}
```
this is the string that rest_framework puts into the web form for any PUTs to edit the field. Therefore the PUT will send the string:
```
"{u'type': u'Point', u'coordinates': [39.921092168090915, 28.04062843322754]}"
```
which will not work with GEOSGeometry as it does not expect the u symbols. The way around this is to eval the string as a python dictionary and then dump the json. This creates the string:
```
'{"type": "Point", "coordinates": [39.921092168090915, 28.04062843322754]}'
```
which will then work.
|
The other maybe cleaner option is to create a JSONDict class that overwrites the str for dict to use json.dumps, i.e. Then returning: JSONDict(json.loads(GEOSGeometry(value).geojson)) from to_representation makes the string: |
Return dictionary with correct json __str__ value
Only update the __str__ of the returned dict
1 similar comment
|
If the solution was ok, it would have been simpler to just return Unfortunately this affects the JSON response too, in which geojson objects become strings. This is a known issue unfortunately. |
|
well actually I was wrong, your solution works. |
|
@nparley could you squash your 4 commits into one commit with a meaningful commit message please? |
nemesifier
pushed a commit
that referenced
this pull request
Jun 27, 2015
Valid for python 2 only.
Avoid representations like {u'type': u'Point', u'coordinates':
[39.921092168090915, 28.04062843322754]}
For more information see #60
nemesifier
added a commit
that referenced
this pull request
Jun 27, 2015
* reintroduced disabled test * avoid double rendering of geojson string * added TODO hint for removing this code when python 2 will be deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When to_representation is run on a geo object json.load adds unicode strings so the result is something like:
this is the string that rest_framework puts into the web form for any PUTs to edit the field. Therefore the PUT will send the string:
which will not work with GEOSGeometry as it does not expect the u symbols. The way around this is to eval the string as a python dictionary and then dump the json. This creates the string:
which will then work.