Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table spacing #184

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Improve table spacing #184

merged 4 commits into from
Nov 17, 2021

Conversation

modiholodri
Copy link
Collaborator

Some tables are still to tight, but all tables are on the plot...
deaths_region_3
vac_region_daily_1_3

@djay
Copy link
Owner

djay commented Nov 13, 2021

@modiholodri I think it looks hard to read the single digits that close.
Maybe we can shorten some names? I still think 2 decimal don't add much for that particular table.

or maybe I solve the whole problem by replacing that vac table with a % one on a different plot. It's maybe not that useful to know how much vax per province per day?

@modiholodri
Copy link
Collaborator Author

@djay Yeah, it's a little bit harder to read but makes it more consistent if there are 3 digits all the time. Might be also that we need another "human formatter" which does not remove the trailing 0s. Also the trailing 0s convey some information and show the precision of the measurement.

@modiholodri
Copy link
Collaborator Author

Not perfect but as good as it gets for now. Could even get the fixed table width to work...
cases_region_3

deaths_region_3

vac_region_daily_1_3

vac_region_daily_2_3

@djay djay merged commit c3c6835 into main Nov 17, 2021
@djay djay deleted the Make-vaccination-tables-fit branch November 17, 2021 05:46
reduxionist pushed a commit that referenced this pull request Nov 22, 2021
* Improve table spacing

* Try to improve tables #187

Co-authored-by: Dylan Jay <github@dylanjay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants