-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use raw identifiers when expanding the macro #473
Comments
I'm open to doing this but only for Rust keywords. Are you willing to submit a PR? |
I am, but why only for Rust keywords? Doing it all the time seems both
simpler and more general.
…On Sat, Apr 17, 2021, 02:05 Dirkjan Ochtman ***@***.***> wrote:
I'm open to doing this but only for Rust keywords. Are you willing to
submit a PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#473 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANP35A63IV2JEGLBCOR5R6LTJFFNZANCNFSM43CN5YTQ>
.
|
It makes the generated code uglier/harder to read -- and it's not like doing it for keywords only incurs a lot of complexity. |
Resolved in #476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When expanding the template macro, it would be nice to replace all of the identifiers defined in the template with raw identifiers in the generated code.
Currently, Rust keywords are sort-of reserved words in the template, in that they trigger weird errors, but they are neither called out as explicit errors nor allowed in working code. Using raw identifiers would allow them to work with no issues.
The text was updated successfully, but these errors were encountered: