fix into_f64 and into_isize #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix up the tests? Ideally we'd add an integration test for this too, to show that it works correctly. |
askama passes references to the filters (e.g. &f64), and &f64 doesn't implement NumCast, only f64 does. So, the filters should take &T instead of T. Fixes djc#357 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
|
Done |
|
Just a little formatting and then it can be merged. 👍 |
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
|
Formatted |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
askama passes references to the filters (e.g. &f64), and &f64 doesn't
implement NumCast, only f64 does.
So, the filters should take &T instead of T.
Signed-off-by: Yuxuan Shui yshuiv7@gmail.com