Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added set alias for let #402

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Added set alias for let #402

merged 2 commits into from
Dec 16, 2020

Conversation

vallentin
Copy link
Collaborator

Related to #329

Added a set alias for let to be more in line with Jinja.

@vallentin vallentin mentioned this pull request Dec 15, 2020
Closed
djc
djc reviewed Dec 15, 2020
View reviewed changes
Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Let's also add a note in the book mentioning this is supported as an alternative, with the exact same semantics as let?

@vallentin
Copy link
Collaborator Author

add a note in the book

I've added a paragraph :)

There's a few issues in relation to the book. So I had just added it to the back burner, to update and include the set alias.

djc
djc approved these changes Dec 16, 2020
View reviewed changes
Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djc djc merged commit 64cf183 into main Dec 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the set-alias branch December 16, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vallentin @djc