Remove panic!() in loop.cycle([])
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
previously approved these changes
Jan 31, 2022
askama_shared/src/generator.rs
Outdated
| @@ -1316,7 +1316,7 @@ impl<'a, S: std::hash::BuildHasher> Generator<'a, S> { | |||
| "cycle" => match args { | |||
| [arg] => { | |||
| if matches!(arg, Expr::Array(arr) if arr.is_empty()) { | |||
| panic!("loop.cycle(…) cannot use an empty array."); | |||
| return Err("loop.cycle(…) cannot use an empty array.".into()); | |||
There was a problem hiding this comment.
This should also not end in a period (I do realize it was there already).
There was a problem hiding this comment.
I removed the period.
Kijewski
force-pushed
the
pr-visit_call-no-panic
branch
from
2d2b830
to
8013389
Compare
Kijewski
force-pushed
the
pr-visit_call-no-panic
branch
from
8013389
to
8a0f580
Compare
|
Fixed one more typo in my change. |
djc
approved these changes
Jan 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.