Allow delimiters with arbitrary length #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
May 31, 2023
askama_derive/src/config.rs
Outdated
| syntax.comment_end, | ||
| ] { | ||
| if s.len() < 2 { | ||
| let msg = format!("Delimiters must be at least two characters long: {s:?}"); |
There was a problem hiding this comment.
Style nits: capitalized error messages, and maybe just inline msg here in these branches?
vallentin
reviewed
May 31, 2023
book/src/configuration.md
Outdated
| @@ -105,8 +105,8 @@ The following keys can currently be used to customize template syntax: | |||
| * `expr_start`, defaults to `{{` | |||
| * `expr_end`, defaults to `}}` | |||
|
|
|||
| Values must be 2 characters long and start delimiters must all start with the same | |||
| character. If a key is omitted, the value from the default syntax is used. | |||
| Values must be 2 at least characters long. | |||
There was a problem hiding this comment.
Suggested change
| Values must be 2 at least characters long. | |
| Values must be at least 2 characters long. |
Phrasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.