fix: misleading error msg when GOOGLE_APPLICATION_CREDENTIALS is not used #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Feb 10, 2024
djc
approved these changes
Feb 19, 2024
|
Thanks! |
|
Cheers for review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you use
CustomServiceAccount::from_json(data)?you will get an error message mentioningGOOGLE_APPLICATION_CREDENTIALS. But given the input data is a string the involvement of aGOOGLE_APPLICATION_CREDENTIALSis an assumption.If you are actually using
SERVICE_ACCOUNT_JSONand passing that environment variable's value asdatathen this error message is misleading.