Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mu4e bug] thread folding hides the next unrelated message in headers view #2478

Closed
3 tasks done
danielfleischer opened this issue May 1, 2023 · 2 comments
Closed
3 tasks done
Labels
bug mu4e specific for mu4e new

Comments

@danielfleischer
Copy link
Contributor

Describe the bug

Newly added thread folding also hides the next message in the list which is not related to the folded thread.

How to Reproduce
Open some mu4e headers view. Fold a thread and see an additional, unrelated message being hidden.

Environment
MacOS, Emacs 30, mu4e 1.11.4.

Checklist

  • you are running either an 1.8.x/1.10.x release or master (otherwise please upgrade)
  • you can reproduce the problem without 3rd party extensions (including Doom/Evil, various extensions etc.)
  • you have read all of the above
@danielfleischer danielfleischer added bug mu4e specific for mu4e new labels May 1, 2023
@progfolio
Copy link
Contributor

looks like an off-by-one error when determining the boundary between the thread to fold and the next thread. This change fixed it for me, but I haven't had a chance to look over the implications outside of the fix:

(defun mu4e-thread-next()
  "Get the root of the next thread (if any)."
  (save-excursion
    (when (mu4e-thread-goto-next)
      (1- (mu4e-thread-root)))))

djcb added a commit that referenced this issue May 5, 2023
@djcb
Copy link
Owner

djcb commented May 6, 2023

Fixed in master.

@djcb djcb closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mu4e specific for mu4e new
Projects
None yet
Development

No branches or pull requests

3 participants