Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-face-property introduces emacs 24.4 requirement #811

Closed
rjhorniii opened this issue Feb 27, 2016 · 6 comments
Closed

add-face-property introduces emacs 24.4 requirement #811

rjhorniii opened this issue Feb 27, 2016 · 6 comments

Comments

@rjhorniii
Copy link

The use of add-face-text-property in mu4e-headers introduces a requirement for emacs 24.4 or later. I think it needs the same kind of protection that it gets in mu4e-view. I'm not sure that will suffice, since it fails in mu4e-headers before it gets to mu4e-view.

@edumerco
Copy link

edumerco commented Mar 7, 2016

I found the same issue, and it makes mu4e unusable in my emacs 24.3.
The strange thing is that is not easy to replicate. At first it dissapeared turning fancy headers to nil, but reappeared afterwards. Same thing happened after commenting all the mu4e-headers marks.

Being in my case a non programmer, how can I help to fix this?

Some related issues in other packages may be:

Thanks...

djcb added a commit that referenced this issue Mar 9, 2016
add-face-text-property was only introduced in emacs 24.4, so check
before use in mu4e-headers as do in mu4e-view.

Fixes issue #811.
@djcb
Copy link
Owner

djcb commented Mar 9, 2016

Fixed -- thanks.

@djcb djcb closed this as completed Mar 9, 2016
@edumerco
Copy link

edumerco commented Mar 9, 2016 via email

@zw963
Copy link

zw963 commented Apr 8, 2016

Report:

Emacs 24.3, update mu4e to 0.9.16, raise this error.

previous, 0.9.13, is work fine.

Thanks.

@zw963
Copy link

zw963 commented Apr 8, 2016

update to github HEAD (0.9.17), it worked now.

btw: need update date to 2016

Copyright (C) 2008-2015 Dirk-Jan C. Binnema

@zw963
Copy link

zw963 commented Apr 8, 2016

Hi, when update to 0.9.17, unread highlight face is not worked now.
I even could not seperate read/unread email.

i have to restore to 0.9.13 ...

my emacs version: 24.3

@djcb djcb mentioned this issue May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants