mu4e: add support for macOS notifications #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current order in this patch is 1) macos notification 2) built-in dbus notification 3) fallback text notification because macOS emacs can actually have dbus enabled (for emacs daemon mode) but that doesn't support notifications. This is a built-in way to send a simple notification for macs, too. Yay!
seanfarley
force-pushed
the
smf/alert
branch
from
c5bb747
to
bbb81ed
Compare
seanfarley
changed the title
|
Looks useful, merged. Thank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for alert.el to be used on systems that don't have native dbus functionality.
Question: is this something that can be applied to the 1.10 branch?
IMHO, this should be on 1.10 just to make 1.10 the release "where notifications work by default." Apologies for not catching this sooner.