mu4e--view-render-buffer: Disable Gnus bookmark-make-record-function

[alphapapa]

The function 'gnus-summary-bookmark-make-record' does not work properly with the
faux "appeasement" summary buffer, causing undesired changes in the window
configuration when the message rendering buffer's bookmark function is
called (which some packages, like Activities, Burly, and Dogears do routinely).

See alphapapa/activities.el#55.

Reported-by: Daniel Goldin https://github.com/danielgoldin

[djcb]

Merged, thanks. Does this apply to 1.12.x as well?

[alphapapa]

Merged, thanks. Does this apply to 1.12.x as well?

Thanks.

Yes, it appears to apply there as well. (I didn't see a release branch for the 1.12 series, so I thought 1.10 was the latest stable series. How does this part of mu's release process work? I didn't see it in the docs but I may have overlooked it.)

[djcb]

Ah, until there are some big / incompatible changes, we do 1.12 releases straight from master. Probably should document that somewhere, indeed!

[alphapapa]

Ok, do I need to send a PR for 1.12 or can you cherry-pick it?

[djcb]

Oh, no worries, I'll cherry-pick in a few days (after travels). Thanks!

[alphapapa]

@djcb Hi again,

I see that on master you merged 7688a2b which no longer "appeases" Gnus. Do you know if that also solves this problem, i.e. preventing Gnus's bookmark-make-record-function from changing the window configuration?

[djcb]

@alphapapa: hopefully so, but I am not 100% sure. Some light testing didn't seem to trigger the problem with "activities".