Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the upcoming org-mode version 9 org-add-link-type is obsolete, so… #917

Merged
merged 1 commit into from Sep 12, 2016

Conversation

kkholst
Copy link
Contributor

@kkholst kkholst commented Sep 4, 2016

… if org-link-set-parameters is bound we will use that instead.

… if org-link-set-parameters is bound we will use that instead.
@kkholst
Copy link
Contributor Author

kkholst commented Sep 6, 2016

Can see this has also been raised as an issue #918

@djcb djcb merged commit 8d345ee into djcb:master Sep 12, 2016
@djcb
Copy link
Owner

djcb commented Sep 12, 2016

Merged -- thanks!

@andersjohansson
Copy link
Contributor

Should it really do both org-add-link-type and org-link-set-parameters? Shouldn't it be:

;; org-add-link-type is obsolete as of org-mode 9.
;; Instead we will use the org-link-set-parameters method
(if (fboundp 'org-link-set-parameters)
    (org-link-set-parameters "mu4e"
                             :follow #'org-mu4e-open
                             :store #'org-mu4e-store-link)
  (org-add-link-type "mu4e" 'org-mu4e-open)
  (add-hook 'org-store-link-functions 'org-mu4e-store-link))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants