fix(types): 🐛 product_images can be missing/undefined from Audible …

…responses, so update the type
laxamentumtech · Sep 2, 2022 · 078cbd3 · 078cbd3
1 parent dd68538
commit 078cbd3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/config/typing/audible.ts b/src/config/typing/audible.ts
@@ -61,7 +61,7 @@ export interface AudibleProduct {
 		language: string
 		merchandising_summary: string
 		narrators?: NarratorOnBook[]
-		product_images: { [key: string]: string }
+		product_images?: { [key: string]: string }
 		program_participation?: string
 		publication_name?: string
 		publisher_name: string

diff --git a/src/helpers/books/audible/ApiHelper.ts b/src/helpers/books/audible/ApiHelper.ts
@@ -104,6 +104,7 @@ class ApiHelper {
 
 	getHighResImage() {
 		if (!this.inputJson) throw new Error(`No input data`)
+		if (!this.inputJson.product_images) return ''
 		return this.inputJson.product_images[1024]
 			? this.inputJson.product_images[1024].replace('_SL1024_.', '')
 			: this.inputJson.product_images[500]?.replace('_SL500_.', '') || ''

diff --git a/tests/helpers/books/audible/ApiHelper.test.ts b/tests/helpers/books/audible/ApiHelper.test.ts
@@ -76,7 +76,7 @@ describe('ApiHelper edge cases should', () => {
 	})
 
 	test('get backup lower res image', () => {
-		helper.inputJson!.product_images[1024] = ''
+		helper.inputJson!.product_images![1024] = ''
 		expect(helper.getHighResImage()).toBe('https://m.media-amazon.com/images/I/51OIn2FgdtL.jpg')
 	})