fix(route): 🐛 nothing could be returned when no genres existed; fixes #…

…255
laxamentumtech · Mar 1, 2022 · 093e2d7 · 093e2d7
1 parent c2b65ea
commit 093e2d7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/config/routes/authors/show.ts b/src/config/routes/authors/show.ts
@@ -96,7 +96,9 @@ async function routes (fastify, options) {
                     return findInDb
                 }
                 // Check state of existing author
-                if (findInDb.genres) {
+                // Only update if either genres exist and can be checked
+                // -or if genres exist on new item but not old
+                if (findInDb.genres || (!findInDb.genres && parseScraper.genres)) {
                     // Only update if it's not nuked data
                     if (parseScraper.genres && parseScraper.genres.length) {
                         console.log(`Updating asin ${request.params.asin}`)
@@ -107,6 +109,8 @@ async function routes (fastify, options) {
                     console.log(`Updating asin ${request.params.asin}`)
                     await updateAuthor()
                 }
+                // No update performed, return original
+                return findInDb
             } else {
                 // Insert stitched data into DB
                 newDbItem = await Promise.resolve(

diff --git a/src/config/routes/books/show.ts b/src/config/routes/books/show.ts
@@ -128,7 +128,9 @@ async function routes (fastify, options) {
                     return findInDb
                 }
                 // Check state of existing book
-                if (findInDb.genres) {
+                // Only update if either genres exist and can be checked
+                // -or if genres exist on new item but not old
+                if (findInDb.genres || (!findInDb.genres && stitchedData.genres)) {
                     // Only update if it's not nuked data
                     if (stitchedData.genres && stitchedData.genres.length) {
                         console.log(`Updating asin ${request.params.asin}`)
@@ -139,6 +141,8 @@ async function routes (fastify, options) {
                     console.log(`Updating asin ${request.params.asin}`)
                     await updateBook()
                 }
+                // No update performed, return original
+                return findInDb
             } else {
                 // Insert stitched data into DB
                 newDbItem = await Promise.resolve(Book.insertOne(stitchedData))