fix(route): 🐛 reply with proper return codes on errors or exceptions

laxamentumtech · Mar 29, 2022 · e34e182 · e34e182
1 parent e6faedc
commit e34e182
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 0 deletions.
diff --git a/src/config/routes/authors/search/show.ts b/src/config/routes/authors/search/show.ts
@@ -5,6 +5,7 @@ async function routes (fastify, options) {
         const name = request.query.name
 
         if (!name) {
+            reply.code(400)
             throw new Error('No search params provided')
         }
 

diff --git a/src/config/routes/authors/show.ts b/src/config/routes/authors/show.ts
@@ -11,6 +11,7 @@ async function routes (fastify, options) {
         // First, check ASIN validity
         const commonHelpers = new SharedHelper()
         if (!commonHelpers.checkAsinValidity(request.params.asin)) {
+            reply.code(400)
             throw new Error('Bad ASIN')
         }
 

diff --git a/src/config/routes/books/chapters/show.ts b/src/config/routes/books/chapters/show.ts
@@ -7,6 +7,7 @@ async function routes (fastify, options) {
         // First, check ASIN validity
         const commonHelpers = new SharedHelper()
         if (!commonHelpers.checkAsinValidity(request.params.asin)) {
+            reply.code(400)
             throw new Error('Bad ASIN')
         }
 
@@ -45,6 +46,7 @@ async function routes (fastify, options) {
                 }
                 return newDbItem
             } else {
+                reply.code(404)
                 throw new Error('No Chapters')
             }
         }

diff --git a/src/config/routes/books/delete.ts b/src/config/routes/books/delete.ts
@@ -6,6 +6,7 @@ async function routes (fastify, options) {
         // First, check ASIN validity
         const commonHelpers = new SharedHelper()
         if (!commonHelpers.checkAsinValidity(request.params.asin)) {
+            reply.code(400)
             throw new Error('Bad ASIN')
         }
 

diff --git a/src/config/routes/books/show.ts b/src/config/routes/books/show.ts
@@ -23,6 +23,7 @@ async function routes (fastify, options) {
         // First, check ASIN validity
         const commonHelpers = new SharedHelper()
         if (!commonHelpers.checkAsinValidity(request.params.asin)) {
+            reply.code(400)
             throw new Error('Bad ASIN')
         }