Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiobooks from audible.de (german audible) has sometime no series data #589

Closed
christopherpross opened this issue Mar 24, 2023 · 1 comment · Fixed by #610
Closed

audiobooks from audible.de (german audible) has sometime no series data #589

christopherpross opened this issue Mar 24, 2023 · 1 comment · Fixed by #610

Comments

@christopherpross
Copy link

Hey,

nice project, thanks for that!

Some audiobooks from audible.de in the audnex-API (public) has no series data. The json-element doesn't exist.

Here are two books that are working and two that aren't working.
Is this a problem off audible? I think not, because the series data is visible on the normal audible website.

Working audiobooks

not working

I hope you can use the sample books, when you need more, I can try to find some and add it here.

@djdembeck
Copy link
Collaborator

djdembeck commented Apr 15, 2023

This seems like an inconsistency on Audible's side. They have the books that are missing series, listed as a SinglePartBook, instead of MultiPartBook. I'll see if I can find a good way around this without losing our data checking process.

djdembeck added a commit that referenced this issue Jun 21, 2023
…ine redundant ApiBook types

After some testing, it seems Audible is inconsistent with how books in a series are labeled. To combat this, we will now allow single and multi part books to contain a series/publication. We can also remove BookSchema, because chapterInfo doesn't seem to ever be attached to a book, so not sure why this was created. Also, since series are optional, we can put those into the main book type

fixes #589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants