Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ch7 invalid sub 2 new db schema + subscription confirmation #6

Merged
merged 17 commits into from
Mar 31, 2024
Merged

Ch7 invalid sub 2 new db schema + subscription confirmation #6

merged 17 commits into from
Mar 31, 2024

Conversation

djdongjin
Copy link
Owner

  1. DB migration to add status column;
  2. Let POST /subscriptions send a confirmation email;
  3. The confirmation email has a link that sends a GET /subscriptions/confirm with a token;
  4. Add GET /subscriptions/confirm handler that verifies the token and update status.

@djdongjin
ch7: [db migration] create new sub-token table
a2bdf14 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: add mock email server and email test
e67fe55 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: send an email in subscription endpoint
af99cf6 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: [test] confirmation email has link
490c732 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: subscriptions handler sends an email with valid link
116d4e7 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: [refactor] move send_confirmation_email to a fn
0f34e2a 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: mark status as pending in subscriptions handler
157fc16 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: add sub confirm route and test template
f9deb09 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: [test] subscribe + confirm
2b41650 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: add base_url to config and actix context
06caedb 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: subscriptions handler adds a random token in confirm link
b54b733 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: [refactor] dedup link parsing from req body
cf40244 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin djdongjin force-pushed the ch7-invalid-sub-2-new-db-schema branch from 387e64a to cf40244 Compare March 31, 2024 06:01
@djdongjin
ch7: [test] token validation in confirm
d7352db 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: move token up as a param
769270d 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: insert subscription token in POST /subscriptions
d8fe1e4 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: /subscriptions/confirm check token and update status
1044b8c 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin
ch7: change POST /subscriptions to sqlx Transaction
e5bf8fc 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@djdongjin djdongjin merged commit f4d85af into main Mar 31, 2024
4 checks passed
@djdongjin djdongjin deleted the ch7-invalid-sub-2-new-db-schema branch March 31, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@djdongjin