Enable lenses to avoid change detection #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability for all `Lens`es to avoid triggering change detection if they don't make any actual change to their target (component or asset). This change modifies the signature of `Lerp::lerp()` to take `&mut dyn Targetable<T>` instead of `&mut T`. The `Targetable<T>` acts as a `Mut<T>`, marking the target as changed only if actually dereferenced mutably. Note that we cannot use `Mut<T>` directly because we can't obtain a `Mut<A: Asset>` without marking the asset as mutable; see bevyengine/bevy#13104. Fixes #91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for all
Lenses to avoid triggering change detection if they don't make any actual change to their target (component or asset).This change modifies the signature of
Lerp::lerp()to take&mut dyn Targetable<T>instead of&mut T. TheTargetable<T>acts as aMut<T>, marking the target as changed only if actually dereferenced mutably.Note that we cannot use
Mut<T>directly because we can't obtain aMut<A: Asset>without marking the asset as mutable; see bevyengine/bevy#13104.Fixes #91