Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry time delta between tweens in a Sequence #39

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Carry time delta between tweens in a Sequence #39

merged 2 commits into from
Aug 3, 2022

Conversation

Gyrobifastigium
Copy link
Contributor

Fixes #36.

djeedai
djeedai requested changes Aug 3, 2022
View reviewed changes
Copy link
Owner

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! That looks ok but I'd rather have test to make sure this works as expected, and doesn't regress in the future. Could you please add something, even very simple?

src/tweenable.rs Show resolved Hide resolved
@Gyrobifastigium
Copy link
Contributor Author

Thanks for the contribution! That looks ok but I'd rather have test to make sure this works as expected, and doesn't regress in the future. Could you please add something, even very simple?

Added a test.

@djeedai djeedai added the bug Something isn't working label Aug 3, 2022
@djeedai djeedai merged commit 77b56f4 into djeedai:main Aug 3, 2022
@djeedai djeedai mentioned this pull request Aug 3, 2022
Closed
inodentry pushed a commit to IyesGames/bevy_tweening that referenced this pull request Aug 4, 2022
@Gyrobifastigium @inodentry
Carry time delta between tweens in a Sequence (djeedai#39)
91652d4
djeedai added a commit that referenced this pull request Aug 4, 2022
@djeedai
Revert "Carry time delta between tweens in a Sequence (#39)"
3637916 
This reverts commit 77b56f4.
djeedai added a commit that referenced this pull request Aug 4, 2022
@djeedai
Revert "Carry time delta between tweens in a Sequence (#39)"
971edb6 
This reverts commit 77b56f4.
djeedai added a commit that referenced this pull request Aug 6, 2022
@djeedai
Revert "Revert "Carry time delta between tweens in a Sequence (#39)""
e59ac35 
This reverts commit 971edb6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeedai djeedai djeedai approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequence::tick accumulates timing error whenever a tween completes
3 participants
@Gyrobifastigium @djeedai @benfrankel