Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all warnings, Support Carthage #18

Closed
wants to merge 3 commits into from
Closed

Fixed all warnings, Support Carthage #18

wants to merge 3 commits into from

Conversation

shoerob
Copy link

@shoerob shoerob commented May 23, 2019

No description provided.

@shoerob shoerob changed the title Fixed all warnings Fixed all warnings, support carthage May 23, 2019
@shoerob shoerob changed the title Fixed all warnings, support carthage Fixed all warnings, Support Carthage May 23, 2019
dji-dev
dji-dev requested changes May 27, 2019
View reviewed changes
Copy link
Contributor

@dji-dev dji-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to revert the project.pbxproj and DJIWidget.xcscheme files changes? As we don't want to support Carthage in our SDK Github repos officially. We have several repos using Cocoapods.

@shoerob
Copy link
Author

shoerob commented May 29, 2019

Sure, I'll resubmit the PR from a different branch.

@shoerob shoerob closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dji-dev dji-dev dji-dev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shoerob @dji-dev