Test provinding values as integers

[infracaninophile]

I'm implementing some new freeradius setups, and this module seems pretty much exactly what I need, except it fails to run complaining about:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Logrotate::Rule[radacct]: parameter 'rotate' expects a value of type Undef or Integer, got String at /etc/puppetlabs/code/environments/freeradius/modules/freeradius/manifests/init.pp:311 on node radius.ab2.staging.gigaclear.net

I made the obvious change as in this pull request, and it seems to fix the problem. Yet there was
clearly a commit fba271f in 2015 that made exactly the opposite change, and this problem is such a clear show-stopper I must be missing something?

This is on CentOS 7, puppet-agent-1.10.8-1.el7.x86_64

[djjudas21]

Thanks for this.

Looks like the dependent module puppet/logrotate implemented parameter data types since I last updated. I guess you're running a version that includes this commit (we're running an older version over here). It's pretty clear that the module expects an integer input so that's what we must give it.

I think the commit against this module in 2015 that added quoting was for neatness, before string vs integer was really a thing, and can safely be ignored. I'm happy to accept this PR as it is - thanks for your effort.