Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code T028 error only applies to Jinja and should be J028 #178

Closed
krukas opened this issue Feb 2, 2022 · 5 comments
Closed

Error code T028 error only applies to Jinja and should be J028 #178

krukas opened this issue Feb 2, 2022 · 5 comments
Assignees
Labels
🔍 linter 🦠 bug Something isn't working
Projects

Comments

@krukas
Copy link

krukas commented Feb 2, 2022

T028 is not a general template error and should have the prefix for Jinja

@krukas krukas added 🦠 bug Something isn't working 🔍 linter labels Feb 2, 2022
@github-actions github-actions bot added this to Needs triage in bugs Feb 2, 2022
@christopherpickering
Copy link
Contributor

Good point, thats valid in njk as well, but I don't think twig. Instead of duplicating the rule for njk I will update the exclude list for the other profiles.

Thanks!

@christopherpickering
Copy link
Contributor

Oh, looks like Django was already excluded. What template lang are you using?
image

@krukas
Copy link
Author

krukas commented Feb 2, 2022

Add the beginning I had no profile (I thought the default is Django, couldn't find what default is) set and was getting this error. I changed the profile to Django and it error disappears.

I still created this issue because it was not a generic template error, and with some google i stumble upon Jinja and that's why I though an Jinja only feature.

I don't know what is cleaner, but maybe you can extend rules. In that way you can apply this rule for Jinja and njk with own prefix?

@christopherpickering
Copy link
Contributor

Yeah, that's probably a better idea.. just enable the generic rules by default, then other specific rules when profiles are set.

@christopherpickering
Copy link
Contributor

Opps, I mentioned the wrong issue in 2acb8c3. That commit fixed this issue. release coming soon. Thanks! @krukas

bugs automation moved this from Needs triage to Closed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 linter 🦠 bug Something isn't working
Projects
bugs
  
Closed
Development

No branches or pull requests

2 participants