Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly named log_file_name parameter for java / ruby agents #264

Open
petergphillips opened this issue Sep 19, 2016 · 1 comment
Open

Comments

@petergphillips
Copy link

templates/default/agent/newrelic.yml.erb sets a log_file parameter. Unfortunately the naming of the parameter isn't consistent amongst the different languages. For python this is correct, but for java and ruby it is called log_file_name instead.

I've manually changed a deployed yml file and confirmed for java that the agent does indeed rely on the name being called log_file_name. From what I can tell that yaml file is only used by the java and ruby agents so should be safe to rename?

petergphillips added a commit to petergphillips/newrelic that referenced this issue Sep 19, 2016
@djoos
Copy link
Member

djoos commented Jul 31, 2017

Hi @petergphillips,

would you mind sending your fix in via a PR?

Thanks in advance!

Kind regards,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants