Adding headers to urlopen requests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make things less of a mess during development: - moved the UI files to their own directory - got rid of the Jenkinsfile since I'm using Github actions instead of Jenkins - got rid of the extralifedonations.spec because I don't think I need it anymore.
Adding in the updated issue templates into devel to prevent a merge conflict in the future. Those were created on the github wesite and put directly into master.
I guess this is a result of the DDOS attack that Extra-life.org suffered on game day, but it started failing grabbing the JSON data. At first I thought it was because I was grabbing http instead of https, but nope. It turns out that now I need to add a user-agent string. Made up my own and that seems to be just fine to get through. The amount of places I had to change this just drives home that I need to do the URLOPEN refactor I've been thinking about for a while. Just didn't want to make drastic changes until after game day.
djotaku
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of the DDOS that Extra-life suffered on game day, headers are required now. So I added headers to my requests and it looks like everything's working OK. (Also, I really need to refactor my code, I've got roughly the same thing happening in 5 (or more) different places!)
Oh yeah, also in this merge I cleaned up the directory a little like moving the .ui files into a folder and getting rid of the Jenkinsfile since I'm using Github actions now.
If all the checks pass, I'll merge and make a new release.