Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claytons not showing FYI cards #276

Closed
2 tasks done
djplaner opened this issue Aug 17, 2023 · 2 comments · Fixed by #278
Closed
2 tasks done

Claytons not showing FYI cards #276

djplaner opened this issue Aug 17, 2023 · 2 comments · Fixed by #278
Labels
bug Something isn't working

Comments

@djplaner
Copy link
Owner

djplaner commented Aug 17, 2023

Currently Claytons isn't showing FYI cards - at least for Griffith Cards.

Check for other representations

  • Assessment Table
  • Horizontal cards
@djplaner djplaner added the bug Something isn't working label Aug 17, 2023
@djplaner
Copy link
Owner Author

djplaner commented Aug 17, 2023

Findings

Horizontal Cards is working fine....Assessment Table and griffith Cards not working

How do they get the modules

  • Horizontal Cards - getRepresentationModules (same as next)
  • Griffith Cards
    return getRepresentationModules( collection, claytons, $collectionsStore["COLLECTIONS"][collection]["unallocated"] );
  • Assessment Table

They all use the same approach - so why is there a difference?? --- the difference is that there are unpublished modules as the FYI......

Make sure it includes the unpublished FYI modules

All work being done in gotCollectionCanvasModule

@djplaner
Copy link
Owner Author

Fixing getCollectionCanvasModules

Use cases

  1. staff view live
  2. staff view generate claytons
  3. student view

Data going in

  • Collections details $collectionStore["MODULES"]
  • Canvas $moduleStore

djplaner added a commit that referenced this issue Aug 17, 2023
djplaner added a commit that referenced this issue Aug 17, 2023
@djplaner djplaner linked a pull request Aug 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant