Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Clients' borders aren't drawn correctly during drag and drop #318

Closed
guyuming76 opened this issue Oct 7, 2022 · 4 comments
Closed

Clients' borders aren't drawn correctly during drag and drop #318

guyuming76 opened this issue Oct 7, 2022 · 4 comments

Comments

@guyuming76
Copy link

guyuming76 commented Oct 7, 2022

i use https://github.com/padgettr/rfm to manage my pictures. In DWM, i can open two instances of rfm and copy/move pictures between them with drag and drop. But it does not work in DWL. why? is it something with wlroots/dwl or gdk/gtk?

when i drop in DWM, i can see handler in rfm called as shown in the screenshot. But in DWL, the handler is not called.

And in DWL, the handler for drag is called when i start dragging.

rfmDnd_DWM_drop1

in dwl log, i can see what follows. looks like rfm is working with xwayland? it is based on gtk+, does it works with wayland natively?

00:02:10.006 [DEBUG] [types/wlr_surface.c:748] New wlr_surface 0x10831b0 (res 0x10cdd60)
00:02:10.008 [DEBUG] [types/wlr_surface.c:748] New wlr_surface 0x10af9b0 (res 0x10ceae0)
00:02:10.008 [DEBUG] [types/data_device/wlr_data_source.c:189] Offering additional MIME type after wl_data_device.set_selection
00:02:10.008 [DEBUG] [types/data_device/wlr_data_source.c:196] Ignoring duplicate MIME type offer text/uri-list
00:02:10.008 [DEBUG] [types/data_device/wlr_data_source.c:189] Offering additional MIME type after wl_data_device.set_selection
00:02:10.009 [DEBUG] [xwayland/selection/incoming.c:486] XCB_XFIXES_SELECTION_NOTIFY (selection=298, owner=2097155)

I tried rebuilding dwl without xwayland, and drag and drop again. Now, the last entry in the logs above disappear, but drop still has no effect.

sevz17 added a commit that referenced this issue Oct 7, 2022
this fixes another issue where the cursor doesn't change when selecting text
but there is still an issue about not changing border color of clients during
dnd operations

Bug: #318
@sevz17
Copy link
Collaborator

sevz17 commented Oct 7, 2022

With the last commit drag and drop should working fine now, I didn't close the issue because still there are problems with the clients' border color

@guyuming76
Copy link
Author

it looks like commit b8bc54b65d7dfaf1c7aa92de32f8ca37d8e011f9 breaks the DnD, it works before.

@sevz17
Copy link
Collaborator

sevz17 commented Oct 8, 2022

f6820a6 didn't fix the issue?

@guyuming76
Copy link
Author

guyuming76 commented Oct 8, 2022

f6820a6 didn't fix the issue?

sorry, i need to try again. there is something wrong with my git merge.

Update: it fixed for me, just that i had something wrong with my git merge

fbievan pushed a commit to fbievan/dwl that referenced this issue Oct 8, 2022
this fixes another issue where the cursor doesn't change when selecting text
but there is still an issue about not changing border color of clients during
dnd operations

Bug: djpohly#318
Signed-off-by: fbievan <17110707+fbievan@users.noreply.github.com>
@sevz17 sevz17 changed the title rfm drag and drop work with dwm but not dwl Clients' borders aren't drawn correctly during drag and drop Oct 15, 2022
@sevz17 sevz17 closed this as completed in 3cc22de Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants