Skip to content
This repository has been archived by the owner on Nov 28, 2017. It is now read-only.

Circular buffer #85

Merged
merged 4 commits into from
Nov 9, 2015
Merged

Circular buffer #85

merged 4 commits into from
Nov 9, 2015

Commits on Nov 6, 2015

  1. Don't write a page unnecessarily 

    Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
    @jonludlam
    jonludlam committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    375fd8f View commit details
    Browse the repository at this point in the history

  2. CA-188133: Use the metadata area properly 

    We currently do not update the position of the last metadata position
when writing the metadata to disk. This means that if you make
multiple updates without rereading, the new metadata will always be
written in the same area of the disk, thus causing apparent corruption
if you're trying to read at the same time (the 'corruption' is
detected by a CRC check, and is only transient).

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
    @jonludlam
    jonludlam committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    cd0ff96 View commit details
    Browse the repository at this point in the history

  3. Fix one of the tests 

    The test was comparing the vg metadata before and after writing
to disk, which fails as the location of the metadata changes.
This fix removes the 'headers' field from the vg metadata, which
contain the locations, before the comparison is made.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
    @jonludlam
    jonludlam committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    8a0dd54 View commit details
    Browse the repository at this point in the history

  4. Really test the circular buffer 

    We now reread the metadata after writing it and look for the
LV in the re-read data. Also, the test is tweaked so that it
actually does wrap around in the metadata area.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
    @jonludlam
    jonludlam committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    abc5260 View commit details
    Browse the repository at this point in the history