This repository has been archived by the owner on May 15, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #51, custom selectors can no longer leverage the bloom filter. I'd like to try and restore that ability in a more (hopefully) palatable way:
Basically,
canMatchIn
takes the role of the oldmatches
method, but with (hopefully) cleaner semantics. Of course, implementations can callGroup.matches(String)
to reproduce the old functionality.For some concrete examples, here are some searches that I'd like to be able to do while leveraging the bloom filter optimization:
e
that have a given name and a given attribute valuee
with a given name and returnf(e)
for some transformf
.e
that contain a child element with a given name.