This repository has been archived by the owner on Nov 27, 2020. It is now read-only.
Issue #15 H264 BufferedPacket nextEnclosedFrameProc singature #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the signature from : func (p *H264BufferedPacket) nextEnclosedFrameSize(buff []byte, size uint) uint32 to func (p *H264BufferedPacket) nextEnclosedFrameSize(buff []byte, size uint32) uint32 Seems to be related to the commit 765284e wackey, 11 months ago (April 14th, 2017 10:29am) "using uint32 replace uint"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the signature from : func (p *H264BufferedPacket) nextEnclosedFrameSize(buff []byte, size uint) uint32
to func (p *H264BufferedPacket) nextEnclosedFrameSize(buff []byte, size uint32) uint32
Seems to be related to the commit 765284e wackey, 11 months ago (April 14th, 2017 10:29am) "using uint32 replace uint"
Not sure how to validate the test yet, I simply managed to read some data from my ip cam:
Stream "rtsp://admin:XX@192.168.48.205/Streaming/Channels/102/"; video/H264: Received 336 bytes. Presentation Time: 383617.000000
Stream "rtsp://admin:XX@192.168.48.205/Streaming/Channels/102/"; video/H264: Received 378 bytes. Presentation Time: 383617.000000