Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial window size not work #1

Closed
djyde opened this issue Dec 21, 2015 · 4 comments
Closed

initial window size not work #1

djyde opened this issue Dec 21, 2015 · 4 comments
Labels
bug help wanted
Milestone
v0.1.7

Comments

@djyde
Copy link
Owner

djyde commented Dec 21, 2015

initialWindowXxx did not work for window but did work for the webview viewport size.

Relevant codes in https://github.com/djyde/WebShell/blob/master/WebShell%2FViewController.swift#L106-L123
@djyde
Copy link
Owner Author

djyde commented Dec 21, 2015

Until the bug fixing, you can manually change initial window size in the storyboard.

@ghost
Copy link

ghost commented Dec 22, 2015

setFrame:display:

@djyde
Copy link
Owner Author

djyde commented Dec 22, 2015

@froge-xyz could you make a Pull Request?

@ghost ghost mentioned this issue Dec 22, 2015
Merged
@ghost
Copy link

ghost commented Dec 22, 2015

@djyde its fixed, please check my PR.

@djyde djyde closed this as completed in 4b82995 Dec 22, 2015
djyde added a commit that referenced this issue Dec 22, 2015
@djyde
Merge pull request #13 from froge-xyz/master
82212b6 
fix #1 initial window size
@djyde djyde added this to the v0.1.7 milestone Dec 22, 2015
@defims defims mentioned this issue Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
v0.1.7
Development

No branches or pull requests
1 participant
@djyde