Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Notification and console.log Support #8

Merged
merged 7 commits into from Dec 23, 2015
Merged

Added Notification and console.log Support #8

merged 7 commits into from Dec 23, 2015

Conversation

0xWDG
Copy link
Collaborator

@0xWDG 0xWDG commented Dec 21, 2015

And as extra Dutch translations

@0xWDG
Copy link
Collaborator Author

0xWDG commented Dec 21, 2015

Baidu.com did not load, so I've temporarily replaced it, just a tip: turn it into the github pages url http://djyde.github.io/WebShell/
And make a nice how to use page and load that one at the first point
I'm thinking about some basic examples and maybe configuration parameters on that page

@djyde
Copy link
Owner

djyde commented Dec 22, 2015

Awesome pull request!

But it seems that _blank to external not work. Had you tested it?

I've merged your branch to dev branch.

Additionally, could you add a param for defining the notification's title?

@0xWDG
Copy link
Collaborator Author

0xWDG commented Dec 22, 2015

I will look tonight at the code for the Notifications and target=_blank. Yesterday I was working on my machine, I will try some other websites also

@djyde
Copy link
Owner

djyde commented Dec 22, 2015

Thanks a lot!

The HTML5 notification API receives an options object param, I don't know how to pass it to native. You could think about it.

@0xWDG
Copy link
Collaborator Author

0xWDG commented Dec 22, 2015

I've looked up the options param, it's not to hard, I'll also try to support custom icons like safari does.

In about 7 hours I'm done with work and then I will look toward to it.

@djyde
Copy link
Owner

djyde commented Dec 22, 2015

Cool. Waiting for your PR

@0xWDG
Copy link
Collaborator Author

0xWDG commented Dec 22, 2015

Fixed: target=_blank
How: Now every time a page is loaded we'll re-inject the web hook.
(checked on multiple pages)

i'm now go and check the notification part and hopefully add some nice options to it.

How: Now every time a page is loaded we'll re-inject the web hook.
@0xWDG
Copy link
Collaborator Author

0xWDG commented Dec 22, 2015

Notifications support now many different ways see also Tests/Notifications.html

I've changed Loading... to a variant what supports translations.

And All issues are gone, and everything is double checked.

@djyde
Copy link
Owner

djyde commented Dec 23, 2015

Awesome.

Pull request into dev branch and I will merge it.

djyde added a commit that referenced this pull request Dec 23, 2015
Added Notification and console.log Support
@djyde djyde merged commit fbd9d25 into djyde:master Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants