Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop time if commit dialog is open #10

Closed
ollin opened this issue Dec 1, 2018 · 2 comments
Closed

Stop time if commit dialog is open #10

ollin opened this issue Dec 1, 2018 · 2 comments

Comments

@ollin
Copy link

ollin commented Dec 1, 2018

Scenario:

Using the clock as the constraint.

editing -> finished work -> open commit dialog one second before the time runs out - add 2 seconds -> limitWip reverts -> change lost

Improvement:

Stop the clock. (not reset) Continue the clock if the dialog closes without commit

@ollin
Copy link
Author

ollin commented Dec 8, 2018

can use "Stop auto-revert" - Shortcut

@ollin ollin closed this as completed Dec 8, 2018
@dkandalov
Copy link
Owner

Implemented as:

  • open commit dialog one second before the time runs out - add 2 seconds
  • no auto-revert, timer reaches timeout but doesn't start over
  • when commit dialog closes auto-revert is done (if all changes were committed, there is nothing to revert) and timer starts ticking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants