Both else and exit() not needed. Clearer intention and lower complexi…

…ty. All paths either return or exit() through class Tools
dkarvounaris · Mar 15, 2023 · a504413 · a504413
1 parent e0aa533
commit a504413
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/gsitemap.php b/gsitemap.php
@@ -277,7 +277,8 @@ public function addLinkToSitemap(&$link_sitemap, $new_link, $lang, &$index, &$i,
             ++$i;
 
             return true;
-        } else {
+        }
+
         $this->recursiveSitemapCreator($link_sitemap, $lang, $index);
         if ($index % 20 == 0 && !$this->cron) {
             $this->context->smarty->assign([
@@ -295,7 +296,8 @@ public function addLinkToSitemap(&$link_sitemap, $new_link, $lang, &$index, &$i,
             ]);
 
             return false;
-            } else {
+        }
+
         if ($this->cron) {
             Tools::redirect($this->context->link->getBaseLink() . 'modules/gsitemap/gsitemap-cron.php?continue=1&token=' . Tools::substr(Tools::hash('gsitemap/cron'), 0, 10) . '&type=' . $new_link['type'] . '&lang=' . $lang . '&index=' . $index . '&id=' . (int) $id_obj . '&id_shop=' . $this->context->shop->id);
         } else {
@@ -311,9 +313,6 @@ public function addLinkToSitemap(&$link_sitemap, $new_link, $lang, &$index, &$i,
                 'id_shop' => $this->context->shop->id,
             ]));
         }
-                exit();
-            }
-        }
     }
 
     /**