Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability derivates broken in latest release #75

Closed
siimav opened this issue Jul 9, 2019 · 5 comments · Fixed by #81
Closed

Stability derivates broken in latest release #75

siimav opened this issue Jul 9, 2019 · 5 comments · Fixed by #81

Comments

@siimav
Copy link

siimav commented Jul 9, 2019

The latest release appears to have broken the stability derivates window on KSP 1.6.1 using RSS/RO/RP-1. This issue happens with every rocket I tried to load up.

screenshot334

@dkavolis
Copy link
Owner

dkavolis commented Jul 9, 2019

Can you give a screenshot of what it looked like in the previous release? I've changed the stability derivatives to show NaN if no stable AoA was found whereas the previous release still computed the derivatives at that AoA which was unstable (and possibly random since the root solver would not converge so the derivative values would be garbage anyway). In regards to rockets, there shouldn't be stable AoA since they don't have enough lift. IMO there should be an input for the angle at which to compute the derivatives in addition to computing them at the stable AoA.

@siimav
Copy link
Author

siimav commented Jul 9, 2019

Reverted the FARc version and this is what I got with the same rocket. Truth be told, I don't really care about the stability derivatives directly. What I do find important is the Static analysis to figure out at what mach values my rocket or re-entry vehicle is statically stable at.

screenshot334

@dkavolis
Copy link
Owner

dkavolis commented Jul 9, 2019

I can display stability derivatives at 0 AoA if there is no stable AoA found if that helps.

@siimav
Copy link
Author

siimav commented Jul 10, 2019

Not sure what that means. I have to ask though - why change the stability derivative system at all because it looked to be working fine before. At least previously the Static analysis tool was definitely giving meaningful values.

@Gordon-Dry
Copy link

Not sure if this is related, but when enabling one of the Transonic Design curves, a second "curve" in black appears nearby - but it's just a line (see left side of picture):
screenshot_2019-07-14--19-09-53

This did not happen in the previous build.

dkavolis added a commit that referenced this issue Oct 24, 2019
Revert NaN stability derivates if stable AoA is not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants