Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Ifs, Parties etc #1123

Merged
merged 1 commit into from
Sep 3, 2021
Merged

More Ifs, Parties etc #1123

merged 1 commit into from
Sep 3, 2021

Conversation

SimLV
Copy link
Contributor

@SimLV SimLV commented Aug 29, 2021

No description provided.

@SimLV SimLV requested a review from Loobinex August 29, 2021 18:26
Loobinex
Loobinex previously approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@Loobinex Loobinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any flaw with it. Tried it with just test maps though, have not played a 10-hour map which could be made with this.

@Loobinex Loobinex dismissed their stale review September 1, 2021 22:36

I'm playing a regular map and am noticing hickups. Will investigate more.

@Loobinex Loobinex merged commit 625ed10 into dkfans:master Sep 3, 2021
@Loobinex Loobinex mentioned this pull request Sep 25, 2021
Closed
@SimLV SimLV deleted the more_ifs branch October 28, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loobinex Loobinex Loobinex left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimLV @Loobinex