SWAP_CREATURE script command #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWAP_CREATURE(NEW_CREATURE_A,[creature]) will now replace the [creature] with whatever is in the test_demon.cfg file
PieterVdc
reviewed
May 19, 2022
src/config_creature.c
Outdated
| newcrtr_desc[n].name = gameadd.crtr_conf.model[n + 1].name; | ||
| newcrtr_desc[n].num = n + 1; | ||
| n++; | ||
| if (n + 1 >= CREATURE_TYPES_MAX) |
There was a problem hiding this comment.
I believe this should be SWAP_CREATURE_TYPES_MAX instead of the normal one, also use that constant for the 128 up top, and check all new CREATURE_TYPES_MAX if they should SWAP_CREATURE_TYPES_MAX instead
PieterVdc
reviewed
May 20, 2022
src/lvl_script_commands_old.c
Outdated
| check_and_auto_fix_stats(); | ||
| creature_stats_updated(crtr_id); | ||
| //TODO SCRIPT rewrite from DD | ||
| //WARNMSG("Swapping creatures is only supported in Deeper Dungeons"); |
There was a problem hiding this comment.
if it now works this comment can go
src/game_merge.h
Outdated
| @@ -203,6 +203,7 @@ struct GameAdd { | |||
|
|
|||
| struct Objects thing_objects_data[OBJECT_TYPES_COUNT]; | |||
| struct ObjectsConfig object_conf; | |||
| struct CreatureModelConfig swap_creature_models[CREATURE_TYPES_MAX]; | |||
There was a problem hiding this comment.
shouldn't it be SWAP_CREATURE_TYPES_MAX here?
src/lvl_script_commands_old.c
Outdated
| do_creature_swap(ncrt_id, crtr_id); | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
for both do_creature_swap and swap_creature if it's not directly logic related to level scripts them selves it shouldn't really be in the lvl_script files
because information does not weigh anything
|
The CreatureData and Creature structs do not seem to fully come from the configs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWAP_CREATURE([new_creature],[old_creature])
Where: the new creature comes from
SwapCreaturesin the [common] block of creatures.cfg.If this is keeperfx.cfg
Then you can put a file called wubble.cfg in your
creatrsfolder or your campaign/pack specific creatures folder.Then if you put
SWAP_CREATURE(WUBBLE,HORNY)in the level script, it would load the creature specific in wubble.cfg instead of the one from horny.cfg