Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imps can pickup spells and specials in possession from neutral ground #1543

Closed
Loobinex opened this issue Jun 15, 2022 · 0 comments · Fixed by #1544
Closed

Imps can pickup spells and specials in possession from neutral ground #1543

Loobinex opened this issue Jun 15, 2022 · 0 comments · Fixed by #1544
Labels
Priority-High Type-Defect
Projects
Release KeeperFX 0.4.9

Comments

@Loobinex
Copy link
Member

Imps will never pick up specials or spellbooks from neutral ground like path or water. But in possession the player now can. This breaks maps.

The function thing_can_be_picked_to_place_in_player_room is not the only thing that determines if these things will be picked up.
@Loobinex Loobinex added this to New in Release KeeperFX 0.4.9 via automation Jun 15, 2022
@Loobinex Loobinex mentioned this issue Jun 16, 2022
Merged
Loobinex added a commit that referenced this issue Jun 16, 2022
@Loobinex @AdamPlenty
Fixed spells/specials picked up in possession from neutral land (#1544)
67c686a 
- Now the possession behavior for spells and specials as it is outside of possession (really this time).
- Rewrote check_place_to_pickup_spell
- Fixes #1543

Co-authored-by: AdamPlenty <58278560+AdamPlenty@users.noreply.github.com>
@Loobinex Loobinex moved this from New to Done in Release KeeperFX 0.4.9 Jun 16, 2022
Loobinex added a commit that referenced this issue Jun 16, 2022
@Loobinex @AdamPlenty
Fixed spells/specials picked up in possession from neutral land (#1544)
436f22a 
- Now the possession behavior for spells and specials as it is outside of possession (really this time).
- Rewrote check_place_to_pickup_spell
- Fixes #1543

Co-authored-by: AdamPlenty <58278560+AdamPlenty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority-High Type-Defect
Projects
No open projects
Release KeeperFX 0.4.9
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made possession pickup rules for library objects the same as regular rules dkfans/keeperfx
1 participant
@Loobinex