Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music source should not be saved in save file #1686

Closed
Loobinex opened this issue Jul 27, 2022 · 4 comments · Fixed by #1883
Closed

Music source should not be saved in save file #1686

Loobinex opened this issue Jul 27, 2022 · 4 comments · Fixed by #1883
Labels
Component-Sound Type-Defect

Comments

@Loobinex
Copy link
Member

Starting a campaign without the -nocd param will stop music from playing during the entire campaign. Exiting the game, and then enabling it before starting again does not enable the music. It should.
@AdamPlenty
Copy link
Contributor

game.flags_cd are the other flags affected?

@Loobinex
Copy link
Member Author

@AdamPlenty The other flags seem fine to be saved, they do not come from the command line.

@AdamPlenty
Copy link
Contributor

Then perhaps we ought to move nocd out of the flags.

@Loobinex
Copy link
Member Author

That might be a good solution.

AdamPlenty added a commit to AdamPlenty/keeperfx that referenced this issue Sep 22, 2022
@AdamPlenty
Music source is no longer saved in save files
ed1de43 
Fixes dkfans#1686
@AdamPlenty AdamPlenty mentioned this issue Sep 22, 2022
Merged
Loobinex pushed a commit that referenced this issue Oct 1, 2022
@AdamPlenty
Music source is no longer saved in save files (#1883)
58e2bcb 
Fixes #1686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Sound Type-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Music source is no longer saved in save files AdamPlenty/keeperfx
2 participants
@Loobinex @AdamPlenty