Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled click-and-drag Bridge building #1851

Merged
merged 44 commits into from
Sep 22, 2022

Conversation

AdamPlenty
Copy link
Contributor

No description provided.

@AdamPlenty AdamPlenty marked this pull request as ready for review September 15, 2022 20:25
@Loobinex
Copy link
Member

Tried it, and I don't like it much, it creates a square bridge instead of a 1 tile wide bridge. That's not something the player would usually want.

Also, if you touch land again, the entire bridge selection disappears. Not only is this not nice, it's also inconsistent with the drag building of other rooms (which simply create brown boundboxes around where you can't build.

@AdamPlenty
Copy link
Contributor Author

AdamPlenty commented Sep 16, 2022

Tried it, and I don't like it much, it creates a square bridge instead of a 1 tile wide bridge. That's not something the player would usually want.

Also, if you touch land again, the entire bridge selection disappears. Not only is this not nice, it's also inconsistent with the drag building of other rooms (which simply create brown boundboxes around where you can't build.

What do you mean by a square Bridge?

As for the roomspace resetting, it's either that, or we end up with situations where the roomspace touches liquid that the player may not be allowed to build on. That'd be horrendously complicated to handle properly

@Loobinex
Copy link
Member

You would want to easily build a bridge from point A to B: image

And in doing so, have it be a single line and not fill up the entire water area.

Unfortunately, the L shape can only go one way at the moment.
However, this requires that all tiles in the L can be built on, and doesn't account for the fact it always builds the row first.
@AdamPlenty AdamPlenty marked this pull request as draft September 16, 2022 21:47
@AdamPlenty
Copy link
Contributor Author

I think, I've got the L-shaped Bridge building working, touch wood. However, I still need to find a way to automatically detect the correct orientation, and search for more cases where it doesn't build properly.

@AdamPlenty AdamPlenty marked this pull request as ready for review September 20, 2022 19:47
@Loobinex Loobinex merged commit a8bf7d7 into dkfans:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants