Trap Property PlaceOnBridge #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert and fixes
not too much consistency, that would be inconsistent with the rest of the project
add new attribute for slab to allow mapmaker to choose what slab allow trap
Replace name placeonroom with foundation
is_unknflg13 was 'is animated' but was unused
revert added flag 0x100
tidy clean
revert foundation
replace PlaceOnRoom with PlaceOnBridge
replace PlaceOnRoom with PlaceOnBridge
replace PlaceOnRoom with PlaceOnBridge
placeonroom -> placeonbridge
fix error
revert change
revert comment change
|
I think it's ready, but is there anything missing? Can it be improved? |
|
does this one make it so all of the slab_attrs come from the cfg files? if so I suppose the hardcoded array can be droped I see you added animated but haven't added it to the cfgs themselves yet though |
add Animated property for future use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new property for trap 'PlaceOnBridge' to allow mapmaker to make traps that can be placed on bridge, also add it to the script command SET_TRAP_CONFIGURATION so it can be changed per map basis.
By default all traps have PlaceOnBridge = 0.