Implemented features #924 and #923: ANY_CREATURE and AT_ACTION_POINT script commands

[SimLV]

No description provided.

[Loobinex]

@SimTheVoid

I tried this code on a map:

IF(PLAYER0,TOTAL_CREATURES > 3)
	NEXT_COMMAND_REUSABLE
	KILL_CREATURE(PLAYER0,ANY_CREATURE,ANYWHERE,1)
ENDIF

Which is how it is described on #923 . Nothing happened, no log messages either. Did I do something wrong, or is it broken?

[Loobinex]

@SimTheVoid
Testing #924 also did not work. In fact, it crashed my game.

I added this script to a map:

ADD_CREATURE_TO_LEVEL(PLAYER0,DRAGON,3,5,5,0)
NEXT_COMMAND_REUSABLE
KILL_CREATURE(PLAYER0,DRAGON,AT_ACTION_POINT[3],1)

Then launched the game and crashed to desktop right away. This was in the log:

Error: Attempt to read from inaccessible memory address.
  in keeperfx.exe at 0023:00596145, base 00400000
  in keeperfx.exe at 0023:0050de5a, base 00400000
  in keeperfx.exe at 0023:00511786, base 00400000
  in keeperfx.exe at 0023:00513a03, base 00400000
  in keeperfx.exe at 0023:005b31b5, base 00400000
  in keeperfx.exe at 0023:005b48ed, base 00400000
  in keeperfx.exe at 0023:005b665e, base 00400000
  in keeperfx.exe at 0023:005b722a, base 00400000
  in keeperfx.exe at 0023:005d7997, base 00400000
  in keeperfx.exe at 0023:00401386, base 00400000
  in KERNEL32.DLL at 0023:7602fa29, base 76010000
  in ntdll.dll at 0023:771376b4, base 770d0000
  in ntdll.dll at 0023:77137684, base 770d0000

[Loobinex]

It does not work as it should, see attached testmap: testmap950.zip

It spawns dragons, why do the dragons not die?

[SimLV]

It does not work as it should, see attached testmap: [testmap950.zip](https://github.com/dkfans/keeperfx/files/6078746> It spawns dragons, why do the dragons not die?

You forgot LEVEL_VERSION(1)

[Loobinex]

Sorry, updated version with level_version(1) that still does not work well: testmap950.zip

Eventually dragons wandering towards the center will die, but the dragons spawn within the action point, yet don't die immediately.

[Loobinex]

Updated version of the testmap: testmap950.zip

I tested it, and overall it works great. Tried all the commands. I don't know why not all units are always picked up though.
In the testmap 10 dragons spawn in a room, Action Point 1 is larger than the room they spawn in, and when they spawn there it kills 10 dragons per tick. But it's clear to see that some dragons survive a bit longer.

Also @SimLV on #923 I requested 'ANY_CREATURE, EVIL_CREATURE and GOOD_CREATURE', the latter two to match the EVIL_CREATURES and GOOD_CREATURES variables. I see these two aren't implemented. Are you planning to do these on this pull, or should I split up #923?