Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can now pick up gold in frail corners #1678

Merged
merged 6 commits into from Jul 28, 2022

Conversation

AdamPlenty
Copy link
Contributor

Fixes #1517

@AdamPlenty AdamPlenty marked this pull request as draft July 24, 2022 19:05
However, I know of no easy way to test this....
@AdamPlenty AdamPlenty marked this pull request as ready for review July 24, 2022 20:12
@Loobinex
Copy link
Member

The cursor is now problematic:

image
On the above image, the cursor is over subtile 8, close enough to the gold on subtile 7 to make it flash. Now the cursor says you mark the slab for digging, the flashing object says you pick up the object,... and what happen? Nothing, if you click nothing happens.
Hover over subtile 7 and you can pick up the gold, but the cursor shows digging. Hover over subtile 9 and you can mark for digging correctly.

Requirements:

  1. Cursor should always match the action that happens when the player clicks.
  2. Objects should only flash if you can directly interact with them

@AdamPlenty
Copy link
Contributor Author

player->thing_under_hand should be cleared when a tile is highlighted for possible tagging.

@AdamPlenty
Copy link
Contributor Author

player->thing_under_hand should be cleared when a tile is highlighted for possible tagging.

Indeed, I cannot reproduce your issue, at least on water. How do I get frail path corners?

@Loobinex
Copy link
Member

Above report only applied when already with gold in hand.

@Loobinex Loobinex merged commit 6657e5a into dkfans:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pick up gold in frail corner
2 participants