Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in RoombaSchedule() if only schedule is on Sunday #8

Closed
dkilgore90 opened this issue Feb 6, 2021 · 0 comments · Fixed by #10
Closed

Infinite loop in RoombaSchedule() if only schedule is on Sunday #8

dkilgore90 opened this issue Feb 6, 2021 · 0 comments · Fixed by #10
Labels
bug Something isn't working

Comments

@dkilgore90
Copy link
Owner

in the while loop at line 501 or 514. I think there's a mismatch in the day of week indexes, with the original assignments using 0-6, and the loop using 1-7.

Workaround: set the schedule to a day other than Sunday
@dkilgore90 dkilgore90 added the bug Something isn't working label Feb 6, 2021
dkilgore90 added a commit that referenced this issue Feb 26, 2021
@dkilgore90
Fix #8 -- infinite loop on Sunday schedule
9fbf291
dkilgore90 added a commit that referenced this issue Feb 26, 2021
@dkilgore90
Fix #8 -- infinite loop on Sunday schedule
83ab8da
@dkilgore90 dkilgore90 linked a pull request Feb 26, 2021 that will close this issue
Fix #8 -- infinite loop on Sunday schedule #10
Merged
dkilgore90 added a commit that referenced this issue Feb 26, 2021
@dkilgore90
Merge pull request #10 from dkilgore90/sundaySchedule
7eb00ee 
Fix #8 -- infinite loop on Sunday schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8 -- infinite loop on Sunday schedule dkilgore90/iRobot
1 participant
@dkilgore90