Fixes has_remote_param_obj_perms

fixes: pulp#4925

CHANGES/4925.bugfix

@@ -0,0 +1,2 @@
+Fixed RBAC related bug where syncing a repository with a predefined remote required specifying the
+remote's HREF at sync time.

pulpcore/app/global_access_conditions.py

@@ -180,10 +180,13 @@ def has_remote_param_obj_perms(request, view, action, permission):
     """
     kwargs = {}
     obj = view.get_object() if view.detail else None
+    context = {"request": request}
+    if obj:
+        context["repository_pk"] = obj.pk
     if action == "partial_update":
         kwargs["partial"] = True
     serializer = view.serializer_class(
-        instance=obj, data=request.data, context={"request": request}, **kwargs
+        instance=obj, data=request.data, context=context, **kwargs
     )
     serializer.is_valid(raise_exception=True)
     if remote := serializer.validated_data.get("remote"):

pulpcore/tests/functional/api/pulp_file/test_rbac.py

@@ -195,11 +195,13 @@ def test_repository_apis(
     alice, bob, charlie = gen_users(["filerepository", "fileremote"])
     # Sync tests
     with bob:
-        repo = file_repository_factory()
         bob_remote = file_remote_factory(manifest_path=basic_manifest_path, policy="on_demand")
+        repo = file_repository_factory(remote=bob_remote.pulp_href)
     body = {"remote": bob_remote.pulp_href}
     try_action(alice, file_bindings.RepositoriesFileApi, "sync", 403, repo.pulp_href, body)
     try_action(bob, file_bindings.RepositoriesFileApi, "sync", 202, repo.pulp_href, body)
+    # Try syncing without specifying a remote
+    try_action(bob, file_bindings.RepositoriesFileApi, "sync", 202, repo.pulp_href, {})
     try_action(charlie, file_bindings.RepositoriesFileApi, "sync", 404, repo.pulp_href, body)
     # Modify tests
     try_action(alice, file_bindings.RepositoriesFileApi, "modify", 403, repo.pulp_href, {})